<html>
<head><meta charset="utf-8"><title>Reviewing &quot;Serialize span hygiene data&quot; · t-compiler/wg-incr-comp · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/index.html">t-compiler/wg-incr-comp</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing.20.22Serialize.20span.20hygiene.20data.22.html">Reviewing &quot;Serialize span hygiene data&quot;</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="202864449"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing%20%22Serialize%20span%20hygiene%20data%22/near/202864449" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing.20.22Serialize.20span.20hygiene.20data.22.html#202864449">(Jul 04 2020 at 08:52)</a>:</h4>
<p>Could someone look at the <code>on_disk_cache.rs</code> part of <a href="https://github.com/rust-lang/rust/pull/72121">https://github.com/rust-lang/rust/pull/72121</a>?<br>
I'm not too familiar with incremental and stable hashing and don't have time to dig into this in more detail.</p>



<a name="202864525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing%20%22Serialize%20span%20hygiene%20data%22/near/202864525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing.20.22Serialize.20span.20hygiene.20data.22.html#202864525">(Jul 04 2020 at 08:55)</a>:</h4>
<p>I'm ready to answer questions about other parts of the PR and hygiene infra.<br>
The most important part is that <code>ExpnId</code> and <code>SyntaxContext</code> are IDs that are sequentially assigned IDs (similar to <code>NodeId</code>s) that are not stable between compilations.</p>



<a name="202864569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing%20%22Serialize%20span%20hygiene%20data%22/near/202864569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing.20.22Serialize.20span.20hygiene.20data.22.html#202864569">(Jul 04 2020 at 08:56)</a>:</h4>
<p>(Assigning <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> as someone in management role.)</p>



<a name="203112616"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing%20%22Serialize%20span%20hygiene%20data%22/near/203112616" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing.20.22Serialize.20span.20hygiene.20data.22.html#203112616">(Jul 07 2020 at 14:52)</a>:</h4>
<p>I'll look at it</p>



<a name="203138750"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing%20%22Serialize%20span%20hygiene%20data%22/near/203138750" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing.20.22Serialize.20span.20hygiene.20data.22.html#203138750">(Jul 07 2020 at 18:09)</a>:</h4>
<p>Thanks!</p>



<a name="204255146"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing%20%22Serialize%20span%20hygiene%20data%22/near/204255146" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Reviewing.20.22Serialize.20span.20hygiene.20data.22.html#204255146">(Jul 17 2020 at 20:29)</a>:</h4>
<p>I posted my thoughts on the PR itself, <a href="https://github.com/rust-lang/rust/pull/72121#issuecomment-660322490">here</a>.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>